feat(skill): require provider lifecycle coverage - #694
Closed
Neonforge98 wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Moved into #693 per request; this PR is superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The ORG2 performance guard treated primary/secondary and A-to-B testing as lifecycle evidence without explicitly separating machine topology from provider-owned source transitions. That allowed a dual-machine sync test to pass while parser identity, compaction/rewrite, active-row hydration, or idempotent rescan behavior remained untested.
The previous continuation fixtures also demonstrated the gap: normalized rows were given the same fabricated family key, so the tests proved the implementation assumption instead of exercising identity markers derived from raw provider artifacts.
Solution
Extend
org2-performance-guardwith a required provider × raw transition × app/UI state × topology matrix.The skill now requires agents to:
The skill metadata now advertises provider lifecycle and true-machine coverage so these checks trigger in the relevant workflows.
Potential risks
This is a methodology-only change and does not alter application runtime behavior. It intentionally makes some future reviews stricter: a change may receive
Performance verdict: blockeduntil its relevant raw provider transition or topology cell is exercised. That can increase verification time, but prevents unsupported green conclusions. Rollback is a normal revert of the skill files.Verification
quick_validate.pyvia an isolateduvenvironment with PyYAML — passed (Skill is valid!).generate_openai_yaml.pyregenerated the interface metadata — passed.SKILL.mdandagents/openai.yaml— passed.git diff --check— passed.UI evidence
No product UI changes. The only UI-facing change is the skill list description, which is text-only and validated through the generated
agents/openai.yaml.