Skip to content

feat(skill): require provider lifecycle coverage - #694

Closed
Neonforge98 wants to merge 1 commit into
developfrom
feat/performance-guard-lifecycle-matrix
Closed

feat(skill): require provider lifecycle coverage#694
Neonforge98 wants to merge 1 commit into
developfrom
feat/performance-guard-lifecycle-matrix

Conversation

@Neonforge98

Copy link
Copy Markdown
Collaborator

Problem

The ORG2 performance guard treated primary/secondary and A-to-B testing as lifecycle evidence without explicitly separating machine topology from provider-owned source transitions. That allowed a dual-machine sync test to pass while parser identity, compaction/rewrite, active-row hydration, or idempotent rescan behavior remained untested.

The previous continuation fixtures also demonstrated the gap: normalized rows were given the same fabricated family key, so the tests proved the implementation assumption instead of exercising identity markers derived from raw provider artifacts.

Solution

Extend org2-performance-guard with a required provider × raw transition × app/UI state × topology matrix.

The skill now requires agents to:

  • verify local ingestion, identity/listability, UI hydration, cloud upload, and remote rendering as separate boundaries;
  • use raw provider artifacts or faithful before/after fixtures for parser, watermark, lineage, and dedupe changes;
  • include assumption-breaking identity fixtures instead of fabricated matching keys;
  • exercise source changes while ORG2 is open, including an old active/open/pinned row;
  • repeat rescan/restart for idempotence;
  • name untested matrix cells instead of claiming broad multi-provider, dual-machine, or full-lifecycle coverage.

The skill metadata now advertises provider lifecycle and true-machine coverage so these checks trigger in the relevant workflows.

Potential risks

This is a methodology-only change and does not alter application runtime behavior. It intentionally makes some future reviews stricter: a change may receive Performance verdict: blocked until its relevant raw provider transition or topology cell is exercised. That can increase verification time, but prevents unsupported green conclusions. Rollback is a normal revert of the skill files.

Verification

  • Official quick_validate.py via an isolated uv environment with PyYAML — passed (Skill is valid!).
  • Official generate_openai_yaml.py regenerated the interface metadata — passed.
  • Prettier check for SKILL.md and agents/openai.yaml — passed.
  • Repository pre-commit hook — passed; no TypeScript or Rust files were staged.
  • git diff --check — passed.
  • Reverse-applied the new rejection rules to the prior continuation tests: fabricated identical family keys are rejected, and Codex append/A-to-cloud evidence cannot be generalized to Claude Code compaction or an active-old-row rescan.
  • Diff inspection found only the two intended skill files and no secrets, personal paths, generated artifacts, or runtime changes.

UI evidence

No product UI changes. The only UI-facing change is the skill list description, which is text-only and validated through the generated agents/openai.yaml.

@Neonforge98

Copy link
Copy Markdown
Collaborator Author

Moved into #693 per request; this PR is superseded.

@Neonforge98 Neonforge98 closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants